search

AmpersandJS / ampersand-subcollection

Filterable, sortable, proxy of a collection that behaves like a collection.
MIT License
21 stars 8 forks source link

Missing serialize() and toJSON() options. #9

Closed jrmyio closed 9 years ago

jrmyio commented 10 years ago

I think the subcollections should really cover serialize() and toJSON().

What is the best way to implement it? I currently copied over the serialize() and toJSON() from ampersand-collection.

ivan-kleshnin commented 10 years ago

+1

aaronmccall commented 9 years ago

What's the use-case @ConneXNL? Subcollections are intended to be a proxy to a collection for filtering, sorting and paging purposes—a view collection, if you will. The serialize() and toJSON() methods are usually used for persistence purposes.

HenrikJoreteg commented 9 years ago

As subcollection is intended to at least mostly mimic and behave like a collection, it makes sense to me to add these methods. Especially if these folks have a use case.

aaronmccall commented 9 years ago

@AmpersandJS/owners, @AmpersandJS/community-leaders, and @ConneXNL: I'm planning to submit a PR soon that will address public API parity with &-collection. Kamil and Philip, I'll be addressing event bubbling too.

wraithgar commented 9 years ago

Moving this to appropriate repos