search

AmpersandJS / ampersand-sync

Provides sync behavior for updating data from ampersand models and collections to the server.
http://ampersandjs.com
MIT License
20 stars 28 forks source link

withCredentials can be provided directly in options #47

Open naugtur opened 9 years ago

naugtur commented 9 years ago

xhr supports withCredentials option for a while now and the docs describing aompersand-sync should not say that you need xhrFields to add withCredentials as a typical case.

(help me find the file and I can PR it)

pgilad commented 9 years ago

For Models: https://github.com/AmpersandJS/ampersand-model/blob/master/README.md#ajaxconfig-modelajaxconfig-or-modelajaxconfig

For Collections: https://github.com/AmpersandJS/ampersand-rest-collection#ajaxconfig-ampersandrestcollectionextend-ajaxconfig-function-----

naugtur commented 9 years ago

There's been much more changes since I created this issue... Thanks for pointing to those. I see other modules are documented in READMEs so it's probably best to doscument sync in its README first, and then fill in the above.

pgilad commented 9 years ago

Yeah I agree.. Although a lot of the ajaxConfig are similar between any module that relies on &-sync