search

AmpersandJS / ampersand-sync

Provides sync behavior for updating data from ampersand models and collections to the server.
http://ampersandjs.com
MIT License
20 stars 28 forks source link

fix #28 - putting the whole ajaxConfig in xhr settings #64

Closed naugtur closed 9 years ago

naugtur commented 9 years ago

I had to change the order of things being applied to make it reasonable.

I still don't like how options get merged in - you can override the whole headers definition with options, bypassing the lowercasing loop etc. See: https://github.com/AmpersandJS/ampersand-sync/pull/64/files#diff-04aff9558c8839f145fd5cc256639700R106 It's a breaking change, but I think I'll have to make it work.

pgilad commented 9 years ago

You dropped useXDR?

naugtur commented 9 years ago

no, it gets merged with everything else.

lukekarrys commented 9 years ago

Looks good to me and tests pass :smile: +1

naugtur commented 9 years ago

v4 is dragging (imho) already. I'm merging it.