search

AmpersandJS / ampersand-sync

Provides sync behavior for updating data from ampersand models and collections to the server.
http://ampersandjs.com
MIT License
20 stars 28 forks source link

Success callback not always called on success. #8

Closed latentflip closed 10 years ago

latentflip commented 10 years ago

I'm fairly sure: https://github.com/AmpersandJS/ampersand-sync/blob/master/ampersand-sync.js#L105 is causing an issue.

There are times when a successful request doesn't return a body (e.g. a delete might 204 with no content), and the body && in the line above I'm assuming is causing the success function not to be called, even though it really should be.

wraithgar commented 10 years ago

You fixed this. Yay for you!