search

AmpersandJS / ampersand-view-switcher

A utility for swapping out views inside a container element.
MIT License
23 stars 13 forks source link

Resolve bug: ending up with 2 views in the container #24

Closed guins closed 8 years ago

guins commented 9 years ago

Bug

Sometimes 2 views were displayed at the same time using the waitForRemove option with a custom hide function calling the removed callback async

Changes

store new view waiting for previous view to be removed in case set method is called during this interval

kamilogorek commented 9 years ago

Looks good. +1 after small adjustments.

guins commented 9 years ago

Thx! I just pushed the small adjustments.

kamilogorek commented 9 years ago

@AmpersandJS/core-team could someone please release it? I dont have my laptop with me here in Japan.

(On the other note, I'll be back in 2 weeks! :))

HenrikJoreteg commented 9 years ago

would love to see a test added for this, would you mind adding one @guins?

wraithgar commented 8 years ago

Rebased this locally against master and the tests all still work, gonna merge this so it goes in w/ the release about to go out.

wraithgar commented 8 years ago

Published as v2.1.0