search

AmpersandJS / ampersand-view-switcher

A utility for swapping out views inside a container element.
MIT License
23 stars 13 forks source link

Append method #30

Closed codepunkt closed 8 years ago

codepunkt commented 8 years ago

View-switcher is great to handle modal dialogs.

To be able to use advanced animation, i need the view prepended instead of appended to the body so i can use sibling selectors like + or ~ to siblings following the view.

This is why i added a prepend boolean option, which defaults to false, adjusted the docs and wrote a unit test to check if the views el is really prepended.

kamilogorek commented 8 years ago

Just a small comment. Other than this :+1:

kamilogorek commented 8 years ago

Perfect, thanks! :+1: @AmpersandJS/core-team

wraithgar commented 8 years ago

Nice addition with no impact on the current use. :+1:

Thank you for submitting this.

wraithgar commented 8 years ago

Published as v2.1.0

codepunkt commented 8 years ago

Great, thanks! :+1: