search

AmpersandJS / ampersand-view

A smart base view for Backbone apps, to make it easy to bind collections and properties to the DOM.
http://ampersandjs.com
MIT License
92 stars 39 forks source link

update testing framework #154

Closed wraithgar closed 8 years ago

wraithgar commented 8 years ago

Switch fully to zuul Add saucelabs config Use node LTS and npm 2 for building

See discussion that led to this here: AmpersandJS/ampersand-filtered-subcollection#26

wraithgar commented 8 years ago

Still trying to work out mouse events in ie11 (got it working in firefox 43 at least)

wraithgar commented 8 years ago

PHEW tests work in all browsers now.

wraithgar commented 8 years ago

These tests could probably be made to work in IE10 and even IE9 if someone who has those is willing to debug and figure out how to properly build mouse click events in the test files, if that's worth it.

imorrison commented 8 years ago

Any update on configuring zuul correctly? It seems that many of the Ampersand repos are not able to run the tests in travis-ci.

wraithgar commented 8 years ago

The tests do run in travis-ci just not for external pull requests (i.e. from forked repos). Without publishing our private key to each repo there's no way around this.

Between the precommit-hooks which run tests locally, and the fact that tests run properly after we've merged a pull request (and we check those before publishing) this is a "good enough" state for now that lets us at least have tests that run.

Sorry for the confusion brought on by having pull request tests fail for external PRs.

imorrison commented 8 years ago

Ah, I see. Thanks for the explanation.

cdaringe commented 8 years ago

@wraithgar, what's the latest here?

wraithgar commented 8 years ago

I think the consensus was that we needed to find a way to make the tests work in ie9/10 and I don't have the available time to do that right now, unfortunately.

imorrison commented 8 years ago

Not sure what the specific requirements are, but Microsoft has 'officially' depreciated IE9/10:

https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support