AmpersandJS / ampersand-view

A smart base view for Backbone apps, to make it easy to bind collections and properties to the DOM.
http://ampersandjs.com
MIT License
92 stars 39 forks source link

Update jsdom to version 8.3.1 🚀 #161

Closed greenkeeperio-bot closed 8 years ago

greenkeeperio-bot commented 8 years ago

Hello :wave:

:rocket::rocket::rocket:

jsdom just published its new version 8.3.1, which is not covered by your current version range.

If this pull request passes your tests you can publish your software with the latest version of jsdom – otherwise use this branch to work on adaptions and fixes.

Happy fixing and merging :palm_tree:


The new version differs by 405 commits .

There are 250 commits in total. See the full diff.


This pull request was created by greenkeeper.io. It keeps your software, up to date, all the time.

Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster :zap:

dschissler commented 8 years ago

@cdaringe jsdom states that after version 7.0 it requires node.js >= 4. Maybe that isn't an issue with the web version but just thought that you should know.

cdaringe commented 8 years ago

thanks @dschissler :) shouldn't be an issue if our build and tests pass! ampersand-view tests do run in-browser

cdaringe commented 8 years ago

i always test prepublish too!