search

AmpersandJS / ampersand-view

A smart base view for Backbone apps, to make it easy to bind collections and properties to the DOM.
http://ampersandjs.com
MIT License
92 stars 39 forks source link

Clear _subviews array on _downsertBindings #195

Closed ruiramos closed 6 years ago

ruiramos commented 7 years ago

As described on #182, the subviews array is not being cleared when the subviews are removed, which means it will contain old view if eventually the parent is re-rendered after remove.

dhritzkiv commented 7 years ago

Looks good to me. Thanks for the tests, too!

dhritzkiv commented 6 years ago

Tests pass locally. Going to merge.