search

AmpersandJS / ampersand

Quickest way to get started with ampersand.
MIT License
812 stars 41 forks source link

Switch out ncp for fs-extra.copy #119

Closed fyockm closed 9 years ago

fyockm commented 9 years ago
HenrikJoreteg commented 9 years ago

Does the transform option do anything in fs-extra, i didn't think that option existed? I'd guess, without having verified this, that the various template strings are not getting replaced.

Basically what it did before, is copy the entire folder, and do a giant {{{ variable }}} replace for anything that matches the known values in that config. That's what the transform stream does. So, maybe after the copy, you'd need to do some kind of directory stream/transform step.

fyockm commented 9 years ago

@HenrikJoreteg I did verify this. fs-extra actually uses an internal version of ncp for the copy, and it accepts the transform option. see here: https://github.com/jprichardson/node-fs-extra/blob/master/lib/copy/ncp.js#L18

HenrikJoreteg commented 9 years ago

ok, cool, cool. thanks @fyockm

kamilogorek commented 9 years ago

Sweet! :+1:

HenrikJoreteg commented 9 years ago

nice :)

fyockm commented 9 years ago

minor bump? I feel like this is more than patch. thoughts?

lukekarrys commented 9 years ago

I think a patch sounds good

fyockm commented 9 years ago

Sold! patch it is!

published as ampersand@3.0.6