search

AmpersandJS / ampersand

Quickest way to get started with ampersand.
MIT License
812 stars 41 forks source link

chalk > colors #64

Closed fyockm closed 9 years ago

fyockm commented 9 years ago

As discussed with @HenrikJoreteg on gitter. For reference, link to chalk.

chalk vs colors to me boils down to a distaste for extending core prototypes. "Doesn't extend String.prototype"

Other benefits include easier readability and maintainability. It's much simpler to determine which strings have a style applied with chalk via common find.

HenrikJoreteg commented 9 years ago

Ran it locally, reviewed visually. Given the simplicity of this change I'll merge/publish.

HenrikJoreteg commented 9 years ago

actually, would you skip the version bump, i'll do that on publish.

fyockm commented 9 years ago

@HenrikJoreteg reverted. sorry, was just trying to make it easier on you.

Would you prefer I squash the two commits?

HenrikJoreteg commented 9 years ago

cool, published as: v2.0.2