AmpersandJS / ampersand

Quickest way to get started with ampersand.
MIT License
812 stars 41 forks source link

File transfer corrupts images in public folder on app generation #75

Closed jeffboyus closed 8 years ago

jeffboyus commented 9 years ago

https://github.com/AmpersandJS/ampersand/blob/master/lib/app/generateApp.js#L37-42

ncp(__dirname + '/../../template/shared', config.projectFolder, 
     transform: function (readable, writeable, file) {
        var transform = new TransformStream(config);
        readable.pipe(transform).pipe(writeable);
    }
}

My guess is that this is related to the TransformStream portion of this code. This needs to be confirmed outside of my own testing environment.

To test:

  1. place an image in: (ampersand root)/template/shared/public/ folder
  2. start up the ampersand app
  3. generate a new test application
    • this should now result in a corrupted image file format in your corresponding directory.

This issue prevents #74 from being complete (if accepted)

kamilogorek commented 9 years ago

@jeffboyus fixed and commented here https://github.com/AmpersandJS/ampersand/commit/0966f7e25d230987382e071762579b5ddd419eab Closing this one. Thanks!