search

AmpersandJS / ampersand

Quickest way to get started with ampersand.
MIT License
812 stars 41 forks source link

fix question name for express - `framework` #77

Closed fyockm closed 9 years ago

fyockm commented 9 years ago

For some reason, the question name for the server framework was changed from "framework" to "serverFramework". The question name dictates the key in the result, which in turn must match generateApp as "framework".

fyockm commented 9 years ago

Can we label this as breaking too? I think it's a pretty important fix.

wraithgar commented 9 years ago

+1

kamilogorek commented 9 years ago

lgtm +1

HenrikJoreteg commented 9 years ago

@wraithgar @kamilogorek thanks for doing this.

@wraithgar did you publish as well? I try to always comment on closed PRs and specify which version it was published in.

HenrikJoreteg commented 9 years ago

Also, of course thanks to @fyockm for fixing! But I just meant thanks for handling the review/merge.

wraithgar commented 9 years ago

This went out with 2.0.4