Closed geek closed 9 years ago
+1 visual w/ only one minor nitpick
Interested in a .travis.yml
?
My gut feeling is that is more of an examples addition, this demo app is supposed to just do a quick wireframe so people can see the basics of ampersand code itself.
Sounds good. Might as well remove the travis integration with this repo then.
@bear should travis be removed from this repo? @wraithgar did you mean that this repo should not be updated to hapi 8?
@fyockm yes, please do remove it - it got added by one of my automation scripts that I've yet tweaked to have per repo exclusions for integrations
/edit I just removed it - sorry for the noise
@fyockm =this repo should definitely be updated to hapi8
@wraithgar ok, I must have misunderstood your comment. So what did you mean should be an examples
addition? The travis.yml
?
Yeah, unless I'm misunderstanding what that file will do (which is very likely)
:+1: this LGTM
@wraithgar we have disabled travis in the AmpersandJS/examples repo, as tests are not required with submitted examples. it might be a good idea to ask for tests with the examples, but I think we didn't want to stifle contribution from the community (at least in the beginning).
Thank you @geek!
Closes #85