Address twin_column_name error in time series histogram plotting

fanshi118 commented 2 years ago

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

[ ] There is an informative high-level description of the changes.
[ ] The description and/or commit message(s) references the relevant GitHub issue(s).
[ ] The commit messages follow these guidelines.
[ ] The commits correspond to relevant logical changes.
[ ] There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

fanshi118 commented 2 years ago

The error occurred, because as we passed plot_data[sample_col] to plot_split_timeseries using plot_timeseries_histograms as our plot_fn, the twin column was no longer part of the dataframe. Scratching the parameter from the kwargs that get passed to plot_timeseries_histograms could prevent us from running into such error.

fanshi118 commented 2 years ago

@fanshi118, you can mark test_HSStep_NegativeBinomial_sparse_shared_y as xfail for now and create an issue for it.

Done.

AmpersandTV / pymc3-hmm

Address twin_column_name error in time series histogram plotting #109