Closed fanshi118 closed 2 years ago
Does the code still throw those
SettingWithCopyWarning
warnings that appear in the example notebook? If so, we need to address those.Also, that example still uses
pickle
d data, which means that it's not immediately reproducible and the exact format of the data isn't clear. Instead, we could use a simple simulation to produce the data (e.g. asin
with Gaussian noise) and make the entire thing easily reproducible for anyone.
The simulated data is addressed in the updated notebook. Let me know if there's any adjustment needed.
I followed the df.loc
approach as suggested in the warnings, but somehow it's still throwing those. When I tried running the same code w/in a notebook cell though, I wouldn't see those warnings. A bit unsure about what could've gone wrong.
I followed the
df.loc
approach as suggested in the warnings, but somehow it's still throwing those. When I tried running the same code w/in a notebook cell though, I wouldn't see those warnings. A bit unsure about what could've gone wrong.
We need to make sure these warnings are gone.
Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.