search

AmpersandTarski / Ampersand

Build database applications faster than anyone else, and keep your data pollution free as a bonus.
http://ampersandtarski.github.io/
GNU General Public License v3.0
40 stars 8 forks source link

Feature/devcontainer maintenance #1260

Closed hanjoosten closed 2 years ago

hanjoosten commented 2 years ago

This PR is about some maintenance with the devcontainer, and also to try out the new way of working with automatic forced formatting.

Michiel-s commented 2 years ago

When checking the commits and changes of this PR I noticed that there is also a commit regarding stale issues and some refactoring. The PR nor the change log mentions anything of this. I think this is bad practice and we shouldn't allow this.

If I was requested to review I would have suggested to a) split the PR or b) update change log and PR description accordingly.

@stefjoosten Please pay attention to this when reviewing code.

hanjoosten commented 2 years ago

Sorry. I plead guilty. I should have mentioned the introduction of the stale-issues bot in the description of this PR.

stefjoosten commented 2 years ago

Nevertheless, thanks for mentioning this, @Michiel @.***>. I need this sort of feedback because I’m not nearly as professional in my behaviour as I want to be. So keep it up… Stef

PS This is also meant to see what happens when I reply by mail.

hanjoosten commented 2 years ago

@stefjoosten when you reply by mail, a lot of sh*t is added to your comment. Also, as you can see above, everyone now could unsubscribe you from this thread ! My advice: Do not use mail to respond to comments, but use the webinterface for that.