search

AmpersandTarski / Ampersand

Build database applications faster than anyone else, and keep your data pollution free as a bonus.
http://ampersandtarski.github.io/
GNU General Public License v3.0
40 stars 8 forks source link

Bugfix/issue 1261 #1263

Closed hanjoosten closed 2 years ago

hanjoosten commented 2 years ago

Issue #1261 was caused by an upgrade of simple-sql-parser-0.4.4 to 0.6.0. Fortunately this upgrade only effected SQL.hs. So I took a version of that file from before the bulk format period (and hence working with simple-sql-parser-0.4.4). I formatted that file and substituted the current SQL.hs file by the formatted old one. That should do the trick for now.

Michiel-s commented 2 years ago

Hi @hanjoosten, when looking at this PR and the diff of SQL.hs I noticed multiple doubleQuoted ... changed into Name ....

I think there is our issue. So why rollback to v0.4? We could also run by those lines and see where we need to correct. What you say?

Michiel-s commented 2 years ago

Nice that you identified the issue so quickly btw!

hanjoosten commented 2 years ago

Hi @hanjoosten, when looking at this PR and the diff of SQL.hs I noticed multiple doubleQuoted ... changed into Name ....

I think there is our issue. So why rollback to v0.4? We could also run by those lines and see where we need to correct. What you say?

No, I think there is more to it than that. btw, you interpreted the changes the wrong way around. The issue is that the constructors Name, QName etc. are no longer available in simple-sql-parser-0.6.0 . So I substituted them with a function that I wrote to simulate them. That seemed a low-risk approach, and I still think it should work. I suspect something inside the simple-sql-parser library has changed as well, but I do not know for sure. I want to sort that out later, because we do not want this fix to last very long. As you said in the title, this one is urgent.