Dawie3565 commented 9 months ago

missed adding DOTs includes for URP Unlit template in depth normal pass

User found and verified fix below error first found in URP 14x 2022.3.19

Error: A BatchDrawCommand is using the pass "DepthNormals" from the shader "PPLevelEditorUnlit" which does not define a DOTS_INSTANCING_ON variant. This is not supported when rendering with a BatchRendererGroup (or Entities Graphics). MaterialID: 4 ("Gizmo"), MeshID: 1 ("Sphere"), BatchID: 1.

Fix: (DepthNormals Pass) 14x

/ase_srp_cond_begin:<140007/

pragma multicompile DOTS_INSTANCING_ON

/ase_srp_cond_end/

/ase_srp_cond_begin:>=140007/

if ASE_SRP_VERSION >=140007

include_with_pragmas "Packages/com.unity.render-pipelines.universal/ShaderLibrary/DOTS.hlsl"

endif

/ase_srp_cond_end/

action review other api versions and update depth normal pass

Dawie3565 commented 8 months ago

Completed waiting review see Git item. #275

Dawie3565 commented 7 months ago

closed in 1.9.3.3