search

AmplifyCreations / AmplifyShaderEditor-Feedback

4 stars 0 forks source link

Billboard node with spherical type shadows misaligned in SRP #277

Open Dawie3565 opened 5 months ago

Dawie3565 commented 5 months ago

Billboard node

BIRP: (tested in 2019.4.31) -- spherical Billboard has no shadows Note: this was tested with billboard node and ASE billboard from editor with same results produced

URP and HDRP 10x12x14x15x16x17x -- spherical type Billboards return misaligned shadows (see screen shot below)

Review compiled code shows also need to update and check all syntax --- Renamed vertex to positionOS --- Renamed ase_normal to normalOS --- Renamed ase_tangent to tangentOS --- Renamed clipPos to positionCS --- Renamed worldPos to positions --- check all others as applicable

image

Dawie3565 commented 5 months ago

Bumping for 1.9.3.4 balance overflow from 1.9.3.3

BOXOPHOBIC commented 4 months ago

I would redesign the node to have inputs for vertex/normal/tangent, instead of the current implementation. Not a big issue, but the workflow is counterintuitive.