AmrDeveloper / GQL

Git Query language is a SQL like language to perform queries on .git files with supports of most of SQL features such as grouping, ordering and aggregations functions
https://amrdeveloper.github.io/GQL/
MIT License
3.3k stars 90 forks source link

CHAR String Function: #13 #19

Closed Lilit0x closed 1 year ago

Lilit0x commented 1 year ago

CHAR String function

Lilit0x commented 1 year ago

I'll squash the commits in about 2 minutes now. Thanks

AmrDeveloper commented 1 year ago

I suggest to only create branches from master to avoid conflicts for example.

After finishing PR, update your fork and then update the local master, then create a new branch for the next PR

Lilit0x commented 1 year ago

I suggest to only create branches from master to avoid conflicts for example.

After finishing PR, update your fork and then update the local master, then create a new branch for the next PR

Yeahh, I forgot to do that for this PR. My bad, the next one will be okay. Do you want to resolve the conflicts or should I?

AmrDeveloper commented 1 year ago

Related to text_char we need to check if it valid or returning default value

let code = inputs[0].as_number() as u32;
if let Some(character) = char::from_u32(code) {
    return Value::Text(character.to_string());
}
return Value::Text("".to_string());

In the current state we just check argument type so we need to return default value of function has problem

Lilit0x commented 1 year ago

Okay, got it

AmrDeveloper commented 1 year ago

I suggest to only create branches from master to avoid conflicts for example. After finishing PR, update your fork and then update the local master, then create a new branch for the next PR

Yeahh, I forgot to do that for this PR. My bad, the next one will be okay. Do you want to resolve the conflicts or should I?

You should resolve it on local machine or using github UI check that lines that has <<< or >>> and do manual merging, if you need any help just write here