liblz4.so is not built with -O3

Amrnasr / lz4

Automatically exported from code.google.com/p/lz4

0 stars 0 forks source link

liblz4.so is not built with -O3 #114

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?

make liblz4.so

What is the expected output? What do you see instead?

not built with -O3

Original issue reported on code.google.com by fullung@gmail.com on 7 Feb 2014 at 6:20

GoogleCodeExporter commented 8 years ago

OK

Original comment by yann.col...@gmail.com on 7 Feb 2014 at 6:22

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

FWIW, ran into this while adding LZ4 support to RocksDB:

https://github.com/facebook/rocksdb/pull/74

Original comment by fullung@gmail.com on 7 Feb 2014 at 9:25

GoogleCodeExporter commented 8 years ago

Thanks for the link Albert.
RocksDB is such a great key-value DB.
You made an excellent job at integrating LZ4 into it.

Original comment by yann.col...@gmail.com on 14 Feb 2014 at 6:29

GoogleCodeExporter commented 8 years ago

Please find in attached file
a wip r114 version
which should correct the "-O3 shared lib compilation issue"
mentioned in this thread.

For your comments and testing

Original comment by yann.col...@gmail.com on 27 Feb 2014 at 7:52

Attachments:

lz4-r114.tar.gz

GoogleCodeExporter commented 8 years ago

Original comment by yann.col...@gmail.com on 27 Feb 2014 at 7:52

Added labels: Priority-Medium
Removed labels: Priority-minor

GoogleCodeExporter commented 8 years ago

LGTM thanks

Original comment by fullung@gmail.com on 27 Feb 2014 at 8:01

GoogleCodeExporter commented 8 years ago

Fixed into r114

Original comment by yann.col...@gmail.com on 12 Mar 2014 at 2:56

Changed state: Fixed