Amrnasr / lz4

Automatically exported from code.google.com/p/lz4
0 stars 0 forks source link

Do not call sudo in Makefile #148

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hello,

Since version r125, Makefile install target call sudo.

In the process of building a package, or testing installation requiring root 
access via sudo is not necessary and an issue.

Package builder, most of time, run as unprivileged user and fake the root 
environment with fakeroot and install binary/libs inside a temporary directory. 
Real installation is done by a package manager.

Putting sudo in the makefile, first unnecessary require sudo to be installed 
and try to escape from the fakeroot to be really root.

Note that uninstall target doesn't call sudo. So you can do make install but 
you have to do sudo make uninstall...

Original issue reported on code.google.com by sebastien.luttringer on 13 Dec 2014 at 4:02

GoogleCodeExporter commented 8 years ago

Original comment by yann.col...@gmail.com on 13 Dec 2014 at 4:03

GoogleCodeExporter commented 8 years ago
Indeed.
This was changed to authorize "make install" to be tested from travis CI.

This is modified within latest "dev" branch :
https://github.com/Cyan4973/lz4/tree/dev

Original comment by yann.col...@gmail.com on 13 Dec 2014 at 4:04

GoogleCodeExporter commented 8 years ago
Fixed into r126

Original comment by yann.col...@gmail.com on 24 Dec 2014 at 2:17