AmruthPillai / Reactive-Resume

A one-of-a-kind resume builder that keeps your privacy in mind. Completely secure, customizable, portable, open-source and free forever. Try it out today!
https://rxresu.me
MIT License
23.5k stars 2.5k forks source link

[Bug] No preview image #2005

Open ajaskiewiczpl opened 3 months ago

ajaskiewiczpl commented 3 months ago

Is there an existing issue for this?

Product Variant

Self-Hosted

Current Behavior

Preview is not visible. screenshot

Expected Behavior

Preview should be visible.

Steps To Reproduce

It is self hosted using docker compose. Preview in editor works fine, as well as PDF download. It just doesn't show on main page. I don't see any errors in console logs or docker logs, so it's hard to troubleshoot. What and where I can check to resolve this issue?

What browsers are you seeing the problem on?

Firefox, Chrome

What template are you using?

None

Anything else?

No response

mrodus commented 2 months ago

Noticing the same thing

rinczefi-user commented 2 months ago

I see that the resume preview feature was removed 👇

The reason was to reduce the load time. ⌛

cc. @AmruthPillai

rinczefi-user commented 2 months ago

What about extracting the preview part into a common library (eg. @reactive-resume/ui)? So, we can use it in the artboard and in the client dashboard page 🤔

ℹī¸ This would require to have atomic template pages.

rinczefi-user commented 2 months ago

💡 For now as a "quick fix", we could use the template image itself.

Adventages Disadventages
We won't have black images on the dashboard The image won't show the actual state of the CV
There is no load time It'll be a little annoying to have the same image if the templates are the same for multiple CVs

Preview

image

What do you think? Thanks!

cc. @ajaskiewiczpl, @mrodus

rinczefi-user commented 2 months ago

I think I found a way to implement the preview easily 😄

I'd like to create a branch and PR if possible @AmruthPillai Thank you!

Demo

image

rinczefi-user commented 1 month ago

@AmruthPillai Can you provide access to me to create branches/PRs, please? Thank you!

rinczefi-user commented 1 month ago

@AmruthPillai Can you provide access to me to create branches/PRs, please? Thank you!

Okay, I see it works with forking the repo. Will do. Thanks!

rinczefi-user commented 1 month ago

This is the PR: https://github.com/AmruthPillai/Reactive-Resume/pull/2032 Thank you! cc. @AmruthPillai