Open ajaskiewiczpl opened 3 months ago
Noticing the same thing
I see that the resume preview feature was removed đ
The reason was to reduce the load time. â
cc. @AmruthPillai
What about extracting the preview part into a common library (eg. @reactive-resume/ui
)?
So, we can use it in the artboard and in the client dashboard page đ¤
âšī¸ This would require to have atomic template pages.
đĄ For now as a "quick fix", we could use the template image itself.
Adventages | Disadventages |
---|---|
We won't have black images on the dashboard | The image won't show the actual state of the CV |
There is no load time | It'll be a little annoying to have the same image if the templates are the same for multiple CVs |
What do you think? Thanks!
cc. @ajaskiewiczpl, @mrodus
I think I found a way to implement the preview easily đ
iframe
to render it and set resume in the useEffect((), [frameRef])
I'd like to create a branch and PR if possible @AmruthPillai Thank you!
@AmruthPillai Can you provide access to me to create branches/PRs, please? Thank you!
@AmruthPillai Can you provide access to me to create branches/PRs, please? Thank you!
Okay, I see it works with forking the repo. Will do. Thanks!
This is the PR: https://github.com/AmruthPillai/Reactive-Resume/pull/2032 Thank you! cc. @AmruthPillai
Is there an existing issue for this?
Product Variant
Self-Hosted
Current Behavior
Preview is not visible.
Expected Behavior
Preview should be visible.
Steps To Reproduce
It is self hosted using docker compose. Preview in editor works fine, as well as PDF download. It just doesn't show on main page. I don't see any errors in console logs or docker logs, so it's hard to troubleshoot. What and where I can check to resolve this issue?
What browsers are you seeing the problem on?
Firefox, Chrome
What template are you using?
None
Anything else?
No response