fix(printer): refine "localhost" matching in printer.service.ts

AmruthPillai / Reactive-Resume

A one-of-a-kind resume builder that keeps your privacy in mind. Completely secure, customizable, portable, open-source and free forever. Try it out today!

https://rxresu.me

MIT License

25.88k stars 2.65k forks source link

fix(printer): refine "localhost" matching in printer.service.ts #2095

Open jbilinski opened 2 weeks ago

jbilinski commented 2 weeks ago

Bug: unable to print if url contains the word "localhost" in any location resulting in the "about:blank", no output path example: http://nonlocalhoster.com would be changed to http://nonhost.docker.internaler.com

proposed: change localhost matching for local dev environments from a url string match to more specific regex that matches host property.

Low Priority
Edge Case
Service resilience

jbilinski commented 2 weeks ago

this was an issue for me, but i think unlikely for many others