Working towards #847: this branch removes various methods to determine in which round a user is, and instead makes use of the rounds_passed method, which counts results. This method was adapted so we can specify which results (by question key) should be counted.
I propose to get rid of the current_round field on the Session model, but before I do, would like to make sure nobody foresees problems with that.
NB: the branch makes more changes than necessary to the congosamediff experiment. It was necessary to adapt this experiment, as this was using the current_round field and associated methods, but some of the logic was hard for me to understand, so I rewrote the code where I thought it could be more to the point. Hope I didn't misinterpret some intentions of the code that way. One thing that will be changed now is that after the practice phase, the rounds will be counted from scratch.
Working towards #847: this branch removes various methods to determine in which round a user is, and instead makes use of the
rounds_passedmethod, which counts results. This method was adapted so we can specify which results (by question key) should be counted.I propose to get rid of the
current_roundfield on theSessionmodel, but before I do, would like to make sure nobody foresees problems with that.NB: the branch makes more changes than necessary to the
congosamediffexperiment. It was necessary to adapt this experiment, as this was using thecurrent_roundfield and associated methods, but some of the logic was hard for me to understand, so I rewrote the code where I thought it could be more to the point. Hope I didn't misinterpret some intentions of the code that way. One thing that will be changed now is that after the practice phase, the rounds will be counted from scratch.