Amsterdam-Music-Lab / MUSCLE

An application to easily set up and run online listening experiments for music research.
https://www.amsterdammusiclab.nl/
MIT License
4 stars 1 forks source link

use join for file paths #1349

Closed Evert-R closed 1 week ago

Evert-R commented 2 weeks ago

This PR replaces formatted strings for creating file paths with os.path.join

resolves: #952

Evert-R commented 2 weeks ago

See comments: perhaps replace the filename + ".py" with f"{filename}.py", which I think is more readable. Definitely revisit the formatting for the consent filepath: when merging the PR as-is, they'd be written to a different path than is currently specified.

Using f-strings do indeed improve readability a bit here. The consent path, I thought I fixed this when I noticed it earlier, but must have forgotten. Good catch ! Thanks