Add timestamp for start of turn

Evert-R commented 2 weeks ago

This PR sets a timestamp start_of_turn in the result of the first card. First when the board has been loaded, then on every third click of a turn.

Closes: #1298

Evert-R commented 2 weeks ago

Yes, only one is needed. I'm still working on this branch.

5 Nov 2024 15:23:18 Berit @.***>:

@.**** commented on this pull request.

In frontend/src/components/MatchingPairs/MatchingPairs.tsx[https://github.com/Amsterdam-Music-Lab/MUSCLE/pull/1350#discussion_r1829442346]:

@@ -152,6 +154,7 @@ const MatchingPairs = ({ };
 const finishTurn = () => {
setStartOfTurn(performance.now());

Why set this here and at line 145? Wouldn't it be enough to do it in one of those two places?

— Reply to this email directly, view it on GitHub[https://github.com/Amsterdam-Music-Lab/MUSCLE/pull/1350#pullrequestreview-2415778324], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AL34TLHCHGTCPFDZLGU4BYDZ7DIERAVCNFSM6AAAAABRF43OYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJVG43TQMZSGQ]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AL34TLGZKB7CP37EWKDG46LZ7DIERA5CNFSM6AAAAABRF43OYKWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTUP7XNBI.gif]

Evert-R commented 2 weeks ago

In terms of analyzing data: I think it would be better to not set the start_of_turn variable on each card, but instead, send a start_of_turn variable within the result object. This will be saved to the results' json data. The response_interval_ms can probably be removed (check with @Lia-JX-Li ), as it can be derived from the timestamps.

start_of_turn is indeed more clear, so I changed it back. I removed the response_interval_ms after consulting with Lia.

Amsterdam-Music-Lab / MUSCLE

Add timestamp for start of turn #1350