Use a Practice ruleset to implement training phases

Amsterdam-Music-Lab / MUSCLE

An application to easily set up and run online listening experiments for music research.

https://www.amsterdammusiclab.nl/

MIT License

4 stars 1 forks source link

Use a Practice ruleset to implement training phases #1360

Open BeritJanssen opened 1 week ago

BeritJanssen commented 1 week ago

Close #92: the rhythm experiments were using a rather awkward setup for their practice phases. Now, they are using a Practice ruleset instead, which has some methods that can be overridden to accomplish the desired behaviour.

BeritJanssen commented 2 days ago

Thanks for your feedback, and sorry for not being specific about what I was hoping to get from the review, but it was exactly this: feedback on code readability.

I'll hold this PR until after the next release, as it also concerns a serious refactor. Will address the comments then.