search

Amsterdam-Music-Lab / MUSCLE

An application to easily set up and run online listening experiments for music research.
https://www.amsterdammusiclab.nl/
MIT License
4 stars 1 forks source link

add experiment about page as Router option #1367

Closed BeritJanssen closed 3 days ago

BeritJanssen commented 6 days ago

This would be an option towards #1337 : the about page can also function as a landing page.

BeritJanssen commented 3 days ago

Yup, I rushed this PR and forgot to pass the slug in the Route, silly mistake. When you do though, this (more specific) route {slug}/about should take precedence over the {slug} route, right? I do think it's a good idea to rework the Experiment component and factor out the consent & redirect/dashboard logic into their own components. Can you open an issue for it?

As we now got yet another feature request for a landing page, which cannot be solved with this approach (as it specifies a landing page for two different experiments), closing this PR. I'm now thinking of a dedicated Django landing app and route, and a React Landing component, which would probably be no more than a wrapper around HTML entered from the Django admin.