search

Amsterdam / django-gisserver

Django speaking WFS 2.0 to expose geo data
Mozilla Public License 2.0
38 stars 10 forks source link

Protect against related field issue #28

Open sposs opened 4 weeks ago

sposs commented 4 weeks ago

Hopefully fixes #24

vdboor commented 1 day ago

Hi! Thanks for offering this fix. It looks like a good first start. I wonder, would it be possible to have some kind of unit test or example for this? That would make it easier to guarantee this is the right fix. TIA!

sposs commented 1 day ago

I've added a test that fails if the patch is not added. Moreover, I see that the previous test cases passed because the feature Restaurant has a field 'name' and the city also has a field 'name', and so there is collision between the field names. I've thus added a field that does not exist in the Restaurant to ensure the resolution of related.

sposs commented 1 day ago

Last commit needed because your pre-commit hooks are a little too strict on the line lengths...