Amulet-Team / Amulet-Map-Editor

A new Minecraft world editor and converter that supports all versions since Java 1.12 and Bedrock 1.7.
https://www.amuletmc.com/
1.77k stars 123 forks source link

[Bug Report] Keypresses not detected while holding down left mouse on button #1049

Open Scroogeee opened 5 months ago

Scroogeee commented 5 months ago

Bug Report

Current Behaviour:

Clicking the "move point 1" or "move point 2" or the "move box" buttons whilst applying keyboard input (WASD or space or shift) for the desired direction doesn't result in any movement.

Expected behavior:

The selection (point) should be moved according to the keyboard input while holding down the corresponding button with left mouse button.

Steps To Reproduce:

1) Open a world in Amulet 2) Select some area by left clicking 3) Click one of the 3 Buttons (see attached screenshot) whilst applying keyboard input in any of the WASD or up (space) or down (Shift) direction 4) See that selection bounding box is not moved.

Environment:

Additional context

Adding debug println statements in _on_held of nudge_button.py shows that evt.action_ids doesn't contain the keypresses, but only ACT_BOX_CLICK.

Those keypresses should be contained in evt.action_ids of _on_held of nudge_button.py so that the

if any((x, y, z)):
    print("any xyz")
    self._move(self._rotate((x, y, z)))

portion of the code is called and (presumably) the points are actually moved.

Attachments

Screenshots

Worlds

gentlegiantJGC commented 4 months ago

More info https://discord.com/channels/324647192583340043/1242041139100389448