search

Amulet-Team / Amulet-Map-Editor

A new Minecraft world editor and converter that supports all versions since Java 1.12 and Bedrock 1.7.
https://www.amuletmc.com/
1.77k stars 123 forks source link

[Bug Report] Incorrect remaining time during world save #1051

Open ICEREG1992 opened 5 months ago

ICEREG1992 commented 5 months ago

Bug Report

Current Behaviour:

While saving the world, Amulet performs two steps-- pre-save operations, then saving chunks. The "elapsed time" counter does not reset between the two steps, but the progress bar does, so while Amulet runs the saving chunks task, the "remaining time" counter is calculated incorrectly.

Expected behavior:

To get an accurate "remaining time" counter, the "elapsed time" counter should reset just like does between running an operation and creating an undo point.

If you wanted to keep the behavior of the "elapsed time" counter showing the time spent on the entire save operation, an internal counter should be set for the "remaining time" counter to use once the pre-save operations are complete.

Steps To Reproduce:

  1. Open a world
  2. Make a large change
  3. Save the world
  4. Observe that during "Saving Chunks." the remaining time counter is not accurate.

Environment:

Screenshots

Screenshot of pre-save operations, which took a long time to complete (Remaining time is inaccurate here because my computer went to sleep during the operation, not due to any issue with the code) image Screenshot of saving chunks, which did not take long to complete, but the progress bar said it would take a very long time image

ICEREG1992 commented 5 months ago

Probably a better image to show what I mean. Because "Elapsed Time" doesn't get reset, remaining time is artificially inflated. image