Amulet-Team / Amulet-Map-Editor

A new Minecraft world editor and converter that supports all versions since Java 1.12 and Bedrock 1.7.
https://www.amuletmc.com/
1.73k stars 122 forks source link

Water and Lava not rendering on 3D Map (Linux) #1098

Open EvilSupahFly opened 2 weeks ago

EvilSupahFly commented 2 weeks ago

Bug Report

Water and Lava blocks aren't being rendered on my 3D map on Linux.

Current Behaviour:

Missing blocks

Expected behavior:

Not missing blocks

Steps To Reproduce:

Launch Amulet on Linux, load a world with lava and/or water

Environment:

Attachments

Log File:

INFO - PyMCTranslate Version 291
Gtk-Message: 18:27:16.995: Failed to load module "xapp-gtk3-module"
INFO - Loading level /home/evilsupahfly/.minecraft/saves/Otherwhere
INFO - Loading level /home/evilsupahfly/.minecraft/saves/Otherwhere
INFO - Downloading java launcher manifest file.
INFO - Downloading java launcher manifest file.
INFO - Finished downloading java launcher manifest file.
INFO - Finished downloading java launcher manifest file.
INFO - OpenGL Version 3.3.0 NVIDIA 560.35.03
INFO - OpenGL Version 3.3.0 NVIDIA 560.35.03
INFO - Finished setting up texture atlas in OpenGL
INFO - Finished setting up texture atlas in OpenGL
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/lava'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/lava.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/barrier'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/barrier.png'
ERROR - Failed to load block model {'model': 'minecraft:block/barrier'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/barrier.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'
ERROR - Failed to load block model {'model': 'minecraft:block/water'}
'/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block/water.png'

Screenshots

Screenshot from 2024-08-27 18-30-22

EvilSupahFly commented 2 weeks ago

So......

I made a new VENV for Python 3.11.9, reinstalled Amulet using pip, and it works fine, but the water/lava textures are missing in my flatpak version, meaning it's likely a flatpak issue.

(amulet-3119) [~] pip install amulet_map_editor
Collecting amulet_map_editor
  Using cached amulet_map_editor-0.10.35-cp311-cp311-linux_x86_64.whl
Collecting Pillow>=10.0.1 (from amulet_map_editor)
  Using cached pillow-10.4.0-cp311-cp311-manylinux_2_28_x86_64.whl.metadata (9.2 kB)
Collecting wxPython (from amulet_map_editor)
  Using cached wxPython-4.2.1-cp311-cp311-linux_x86_64.whl
Collecting numpy~=1.17 (from amulet_map_editor)
  Using cached numpy-1.26.4-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (61 kB)
Collecting pyopengl~=3.0 (from amulet_map_editor)
  Using cached PyOpenGL-3.1.7-py3-none-any.whl.metadata (3.2 kB)
Collecting packaging (from amulet_map_editor)
  Using cached packaging-24.1-py3-none-any.whl.metadata (3.2 kB)
Collecting amulet-core~=1.9 (from amulet_map_editor)
  Using cached amulet_core-1.9.25-py3-none-any.whl.metadata (4.3 kB)
Collecting amulet-nbt~=2.0 (from amulet_map_editor)
  Using cached amulet_nbt-2.1.3-cp311-cp311-linux_x86_64.whl
Collecting pymctranslate~=1.2 (from amulet_map_editor)
  Using cached PyMCTranslate-1.2.28-py3-none-any.whl.metadata (2.2 kB)
Collecting minecraft-resource-pack~=1.3 (from amulet_map_editor)
  Using cached minecraft_resource_pack-1.4.4-py3-none-any.whl.metadata (965 bytes)
Collecting platformdirs~=3.1 (from amulet_map_editor)
  Using cached platformdirs-3.11.0-py3-none-any.whl.metadata (11 kB)
Collecting portalocker~=2.4 (from amulet-core~=1.9->amulet_map_editor)
  Using cached portalocker-2.10.1-py3-none-any.whl.metadata (8.5 kB)
Collecting amulet-leveldb~=1.0b0 (from amulet-core~=1.9->amulet_map_editor)
  Using cached amulet_leveldb-1.0.2-cp311-cp311-linux_x86_64.whl
Collecting lz4~=4.3 (from amulet-core~=1.9->amulet_map_editor)
  Using cached lz4-4.3.3-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (3.7 kB)
Collecting mutf8~=1.0 (from amulet-nbt~=2.0->amulet_map_editor)
  Using cached mutf8-1.0.6-cp311-cp311-linux_x86_64.whl
Collecting six (from wxPython->amulet_map_editor)
  Using cached six-1.16.0-py2.py3-none-any.whl.metadata (1.8 kB)
Using cached amulet_core-1.9.25-py3-none-any.whl (273 kB)
Using cached minecraft_resource_pack-1.4.4-py3-none-any.whl (443 kB)
Using cached numpy-1.26.4-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (18.3 MB)
Using cached pillow-10.4.0-cp311-cp311-manylinux_2_28_x86_64.whl (4.5 MB)
Using cached platformdirs-3.11.0-py3-none-any.whl (17 kB)
Using cached PyMCTranslate-1.2.28-py3-none-any.whl (1.1 MB)
Using cached PyOpenGL-3.1.7-py3-none-any.whl (2.4 MB)
Using cached packaging-24.1-py3-none-any.whl (53 kB)
Using cached lz4-4.3.3-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.3 MB)
Using cached portalocker-2.10.1-py3-none-any.whl (18 kB)
Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Installing collected packages: pyopengl, mutf8, six, portalocker, platformdirs, Pillow, packaging, numpy, lz4, amulet-leveldb, wxPython, amulet-nbt, pymctranslate, minecraft-resource-pack, amulet-core, amulet_map_editor
Successfully installed Pillow-10.4.0 amulet-core-1.9.25 amulet-leveldb-1.0.2 amulet-nbt-2.1.3 amulet_map_editor-0.10.35 lz4-4.3.3 minecraft-resource-pack-1.4.4 mutf8-1.0.6 numpy-1.26.4 packaging-24.1 platformdirs-3.11.0 portalocker-2.10.1 pymctranslate-1.2.28 pyopengl-3.1.7 six-1.16.0 wxPython-4.2.1
(amulet-3119) [~] python -m amulet_map_editor
INFO - PyMCTranslate Version 298
INFO - Loading level /home/seann/.minecraft/saves/Otherwhere
INFO - Loading level /home/seann/.minecraft/saves/Otherwhere
INFO - No OpenGL_accelerate module loaded: No module named 'OpenGL_accelerate'
INFO - No OpenGL_accelerate module loaded: No module named 'OpenGL_accelerate'
INFO - Downloading java launcher manifest file.
INFO - Downloading java launcher manifest file.
INFO - Finished downloading java launcher manifest file.
INFO - Finished downloading java launcher manifest file.
INFO - Creating texture atlas
INFO - Creating texture atlas
INFO - Trying to pack textures into image of size 4096x4096
INFO - Trying to pack textures into image of size 4096x4096
INFO - Successfully packed textures into an image of size 4096x4096
INFO - Successfully packed textures into an image of size 4096x4096
INFO - Finished creating texture atlas
INFO - Finished creating texture atlas
INFO - OpenGL Version 3.3.0 NVIDIA 560.35.03
INFO - OpenGL Version 3.3.0 NVIDIA 560.35.03
INFO - Finished setting up texture atlas in OpenGL
INFO - Finished setting up texture atlas in OpenGL

Screenshot from 2024-08-28 12-50-43

gentlegiantJGC commented 2 weeks ago

Is it possible that you aren't picking up those assets in the packaging process? Are you able to inspect the package and see if those assets exist? They are part of the model reader library.

EvilSupahFly commented 2 weeks ago

The packaging process for Flatpak involves downloading everything first, then building a sandbox. I'm assuming that the models are included in the dependency chain or part of a package that should already be included?

After work tonight, I'm going to try debugging the build process and see if I can pinpoint what's going on.

I'm also going to compare my Flatpak to the one GIT builds through the work flow and see if I'm doing something different.

At this point though, I'm just happy the Flatpak version doesn't vomit up errors all over my desk when I run it. 😅

EvilSupahFly commented 2 weeks ago

I did have some trouble getting the flatpak to even build properly in the first place. I don't know why, but flatpak-builder was never able to install LZ4 with PIP. I had to go to https://pypi.org/project/lz4/#files to get the direct-download link and SHA hash, then manually add them to the manifest, so I'm wondering if flatpak-builder is experiencing something similar with the missing textures.

EvilSupahFly commented 2 weeks ago

So, the artifact built by GIT using their Flatpak Workflow also suffers from these missing textures, and I don't know why. Nothing shows up in the debug log indicating a problem, so I'm guessing that flatpak-builder somehow doesn't know it needs them.

Screenshot from 2024-08-30 14-55-13

My plan is to try to add the missing stuff as a shared module, which I did by tar.gzipping the folder primary from the pip-installed version in my VENV and adding its own "installer YML" file so it can be gunzipped by flatpak-builder in it's proper pip-installed location as the flatpak is built. At the time of writing, I logged in to my machine remotely during my lunch break to begin rebuilding the flatpak from scratch with the new "shared module" for the textures, which I expect to finish by the time I get home from work so I can test, though all things considered, I'm still happy overall with this flatpak project.

EvilSupahFly commented 2 weeks ago

Well, according to the debug shell, everything is where it's supposed to be, so I don't know why it's missing the textures. The timestamp inside the flatpak's sandboxed filesystem shouldn't matter, right?

[/app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/textures/block] ls -Fla
total 36
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 ./
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 ../
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 banner/
-rw-r--r-- 2 evilsupahfly evilsupahfly  651 Dec 31  1969 barrier.png
-rw-r--r-- 2 evilsupahfly evilsupahfly 1265 Dec 31  1969 end_portal.png
-rw-r--r-- 2 evilsupahfly evilsupahfly  213 Dec 31  1969 grass.png
-rw-r--r-- 2 evilsupahfly evilsupahfly 1286 Dec 31  1969 lava.png
-rw-r--r-- 2 evilsupahfly evilsupahfly 1405 Dec 31  1969 structure_void.png
-rw-r--r-- 3 evilsupahfly evilsupahfly  927 Dec 31  1969 water.png
gentlegiantJGC commented 1 week ago

It is the block model that it can't load. These are json files in minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/models/block

EvilSupahFly commented 1 week ago

You've uncovered the issue:

evilsupahfly on Black-Beast at Mon 2 Sep 2024 08:51:16 EDT
[~] flatpak run --command=sh --devel --filesystem=/app io.github.evilsupahfly.amulet-flatpak
[📦 io.github.evilsupahfly.amulet-flatpak ~]$ cd /app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/block
sh: cd: /app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft/block: No such file or directory
[📦 io.github.evilsupahfly.amulet-flatpak ~]$ cd /app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft
[📦 io.github.evilsupahfly.amulet-flatpak minecraft]$ ls -Fla
total 20
drwxr-xr-x 5 evilsupahfly evilsupahfly 4096 Dec 31  1969 ./
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 ../
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 blockstates/
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 models/
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 textures/
[📦 io.github.evilsupahfly.amulet-flatpak minecraft]$ 

I didn't realize it was looking for some .JSON files. I had assumed the error meant it couldn't locate the texture images, which were clearly present when in fact it's the .JSON files that are missing. It doesn't explain why they're missing though. Aren't they part of minecraft-resource-pack?

  - name: python3-minecraft-resource-pack
    buildsystem: simple
    build-commands:
      - >-
        pip3 install --verbose --no-index --find-links="file://${PWD}"
        --prefix=${FLATPAK_DEST} "minecraft-resource-pack"
        --report=pip_report.json --no-build-isolation
    sources:
      - type: file
        url:  https://files.pythonhosted.org/packages/70/bd/172abef53c86d3e84d7436a484dd57c0f4d62c125ff2dd139394d2f70970/minecraft_resource_pack-1.4.4-py3-none-any.whl
        sha256: 84047a45a8a94b14b63589f3cb7a897f3bccb2632ab40d8b665d89808ebbddd4

I can include them manually, but it doesn't really solve the reason for the issue.

EvilSupahFly commented 1 week ago

Actually, my bad. It's not included - I just looked at the .whl I manually downloaded: Screenshot from 2024-09-02 09-13-48

So if minecraft_resource_pack-1.4.4-py3-none-any.whl doesn't provide the .JSON descriptors, where do they come from?

gentlegiantJGC commented 1 week ago

They are in models/block

EvilSupahFly commented 1 week ago

So I'm still wrong then. They're actually right where they're supposed to be inside the flatpak:

[📦 io.github.evilsupahfly.amulet-flatpak ~]$ cd /app/lib/python3.11/site-packages/minecraft_model_reader/api/resource_pack/java/java_vanilla_fix/assets/minecraft
[📦 io.github.evilsupahfly.amulet-flatpak minecraft]$ ls -Fla
total 20
drwxr-xr-x 5 evilsupahfly evilsupahfly 4096 Dec 31  1969 ./
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 ../
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 blockstates/
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 models/
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 textures/
[📦 io.github.evilsupahfly.amulet-flatpak minecraft]$ cd models/block
[📦 io.github.evilsupahfly.amulet-flatpak block]$ ls -Fla
total 204
drwxr-xr-x 9 evilsupahfly evilsupahfly 4096 Dec 31  1969 ./
drwxr-xr-x 3 evilsupahfly evilsupahfly 4096 Dec 31  1969 ../
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 banner/
-rw-r--r-- 2 evilsupahfly evilsupahfly  133 Dec 31  1969 barrier.json
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 bed/
-rw-r--r-- 2 evilsupahfly evilsupahfly 1525 Dec 31  1969 bed_foot.json
-rw-r--r-- 2 evilsupahfly evilsupahfly 1535 Dec 31  1969 bed_head.json
-rw-r--r-- 2 evilsupahfly evilsupahfly 1610 Dec 31  1969 bell_between_walls.json
-rw-r--r-- 2 evilsupahfly evilsupahfly 1507 Dec 31  1969 bell_ceiling.json
-rw-r--r-- 2 evilsupahfly evilsupahfly 2669 Dec 31  1969 bell_floor.json
-rw-r--r-- 2 evilsupahfly evilsupahfly 1592 Dec 31  1969 bell_wall.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  153 Dec 31  1969 black_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  151 Dec 31  1969 blue_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  153 Dec 31  1969 brown_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly 1855 Dec 31  1969 chest_base.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  105 Dec 31  1969 chest.json
-rw-r--r-- 2 evilsupahfly evilsupahfly 1537 Dec 31  1969 chest_left_base.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  115 Dec 31  1969 chest_left.json
-rw-r--r-- 2 evilsupahfly evilsupahfly 1527 Dec 31  1969 chest_right_base.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  117 Dec 31  1969 chest_right.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  579 Dec 31  1969 conduit.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  151 Dec 31  1969 cyan_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  104 Dec 31  1969 ender_chest.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  139 Dec 31  1969 end_portal.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  109 Dec 31  1969 grass.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  151 Dec 31  1969 gray_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  153 Dec 31  1969 green_shulker_box.json
drwxr-xr-x 4 evilsupahfly evilsupahfly 4096 Dec 31  1969 head/
-rw-r--r-- 2 evilsupahfly evilsupahfly  134 Dec 31  1969 lava.json
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 light/
-rw-r--r-- 2 evilsupahfly evilsupahfly  163 Dec 31  1969 light_blue_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  163 Dec 31  1969 light_gray_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  151 Dec 31  1969 lime_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  157 Dec 31  1969 magenta_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  151 Dec 31  1969 moving_piston.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  155 Dec 31  1969 orange_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  151 Dec 31  1969 pink_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  155 Dec 31  1969 purple_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  149 Dec 31  1969 red_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  141 Dec 31  1969 shulker_box.json
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 sign/
-rw-r--r-- 2 evilsupahfly evilsupahfly  147 Dec 31  1969 structure_void.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  106 Dec 31  1969 trapped_chest.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  116 Dec 31  1969 trapped_chest_left.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  118 Dec 31  1969 trapped_chest_right.json
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 wall_banner/
-rw-r--r-- 2 evilsupahfly evilsupahfly 1208 Dec 31  1969 wall_banner.json
drwxr-xr-x 2 evilsupahfly evilsupahfly 4096 Dec 31  1969 wall_sign/
-rw-r--r-- 2 evilsupahfly evilsupahfly  135 Dec 31  1969 water.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  153 Dec 31  1969 white_shulker_box.json
-rw-r--r-- 2 evilsupahfly evilsupahfly  155 Dec 31  1969 yellow_shulker_box.json
gentlegiantJGC commented 1 week ago

The error comes from here. Can you modify the exception to get a bit more info on what is going wrong? https://github.com/gentlegiantJGC/Minecraft-Model-Reader/blob/ee65d7694acba5cbbc62cb57db2f5d33d520630d/minecraft_model_reader/api/resource_pack/java/resource_pack_manager.py#L240

EvilSupahFly commented 1 week ago

This is new.... Or, I never noticed it before, but I don't think it's causing a problem. I still built minecraft_resource_pack-1.4.4+1.g9905a93-py3-none-any.whl with a modified resource_pack_manager.py which I'm going to use for the flatpak in place of the original, to see what happens.

!!

        ********************************************************************************
        Please avoid running ``setup.py`` directly.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
        ********************************************************************************

!!
gentlegiantJGC commented 1 week ago

Did you run setup.py directly? It still works but you shouldn't call it directly any more.

EvilSupahFly commented 1 week ago

I did because that's how the Flatpak setup runs it, so I was looking for clues.

gentlegiantJGC commented 1 week ago

Probably outdated. If you need to create a .whl file use pypa/build as the error suggests. If you just want to install just use pip install <path>

EvilSupahFly commented 1 week ago

Well, I stepped through the process of launching Flatpak Amulet with PDB (results here) but I don't see anything useful relating to the error. I've checked, double checked, and triple checked that all the .PNG and .JSON files are in their respective directories and nothing appears to be different from the Amulet running in my VENV.

So now I've added breakpoint() to resource_pack_manager.py#L227, pushing everything else down a line and rebuilt the wheel (this time using python -m build). Stepping through manually just took WAAAAAAAY too much time. We'll see what turns up in the next few days.