search

AmyAmy / node-red-contrib-moving-average

A moving average node for Node-RED.
Do What The F*ck You Want To Public License
2 stars 2 forks source link

min/max and status #12

Closed magma1447 closed 9 months ago

magma1447 commented 10 months ago

I had the need for min/max and therefore forked and added that functionality. I also added a node status to make it clearer in the web-ui what's happening.

I have been running the two patches for almost a year without issues, and therefore hope that you would accept them.

AmyAmy commented 10 months ago

Hi, thanks for your PR!

code looks fine, and absolutely willing to merge.

however: I must admit, I had no clue there were actually people using this. The systems I wrote this for don't exist anymore (making testing hard), and kinda forgot what to do to make a new version available in Node Red.

Any suggestions what would be the best way to continue without breaking systems which depend in this package?

magma1447 commented 10 months ago

I actually have no clue. I have never created my own node for node-red. I have only made a few patches and pull requests.

If you don't use it yourself I can fully understand that you don't want to spend too much time on it. But merging it into master and not making a release is also an alternative. Then the code is at least merged.