AmyMialeeMods / no-enchant-cap

A simple mod to enhance some aspects of enchanting.
https://discord.gg/P4dUsxv6An
Other
3 stars 16 forks source link

Feather Falling gives you additional hp. #32

Closed RuZZnGG closed 1 year ago

RuZZnGG commented 1 year ago

When you wear boots with Feather Falling (even don't need to be higher than level 4), instead of loosing less hp, you not only take no damage, you receive an "absorption" effect additional hearts.

buttermyeggrolll commented 1 year ago

This happens when having 4 pieces of protection 4 and Feather-Falling 4, it doesn't happen when only having boots with Protection 4 and Feather-Falling 4. Though it also happens if you have any pieces of armor with non-vanilla level of protection (Protection 5 and above). I would love it if this got fixed because it kind-of ruins the game. Having mixed protection enchants doesn't give extra hearts, only when feather falling gets added or when the protection level goes above 4. These extra absorption hearts also go up basically infinitely, at some point I had so many hearts half my screen was blocked. These hearts don't go away unless you take damage without the armor on, and then you would have to sit there and wait for all of the hearts to disappear. Milk and even the command "/effect clear" doesn't get rid of the hearts.

SCGCrew commented 1 year ago

Using the End fountain also works to clear the additional hearts.

RupeeMiner commented 1 year ago

In an attempt to avoid the feather falling issue, I reverted to the previous forge version of the mod, and it "too expensive" still shows up no matter what I do. Renaming the item appears to make it go away, but when clicked on, it takes your levels until you get more experience and reverts to showing the "too expensive" text

AmyMialee commented 1 year ago

In an attempt to avoid the feather falling issue, I reverted to the previous forge version of the mod, and it "too expensive" still shows up no matter what I do. Renaming the item appears to make it go away, but when clicked on, it takes your levels until you get more experience and reverts to showing the "too expensive" text

if you're using the mod client side it's impossible for too expensive to appear

AmyMialee commented 1 year ago

When you wear boots with Feather Falling (even don't need to be higher than level 4), instead of loosing less hp, you not only take no damage, you receive an "absorption" effect additional hearts.

is this on forge or fabric and does it happen on the other one

RuZZnGG commented 1 year ago

When you wear boots with Feather Falling (even don't need to be higher than level 4), instead of loosing less hp, you not only take no damage, you receive an "absorption" effect additional hearts.

is this on forge or fabric and does it happen on the other one

Fabric, i don't know if Forge version have the issue.

CaramelTurbine commented 1 year ago

Im having this issue as well. Even if its a vanilla issue, and cant be fixed, could you add configs for new enchant caps, or allow admins to specify which enchantments can be stacked?

VibronicSine commented 1 year ago

It also happens with full Projectile Protection IV set and getting shot by an arrow (from dispenser or skeleton or other source). I think it's related to how you've implemented the workaround for the 80% damage reduction cap from all the different types of protection enchantments. Because for example a full set of projectile protection IV would get you way past the 80% cap (it's 8% per level so a full set would be 128% theoretically. And I just tested also the higher damage you take the more hearts you get.

I have also just tested with regular protection getting it up past the 80% cap and going to 96%, 100% and 104%. And I found that anything above 100% will give the absorption hearts. I personally think it should never even get to 100% damage reduction and should be applied multiplicatively past 80%. Or at least an option to enable/disable the protection cap for a more vanilla experience.

And finally, testing on forge version reproduces the same issue.

amer776 commented 1 year ago

Hey did you ever find a solution for this problem

AmyMialee commented 1 year ago

fixed 2.2.6

amer776 commented 1 year ago

I know this issue is closed but can you make the same fix but for version 1.19.2 fabric, or make the 2.2.6 1.19.3 release work with 1.19.2 fabric