search

AmyOlex / Chrono

Parsing time normalizations from text.
GNU General Public License v3.0
15 stars 4 forks source link

Can't convert "sep" to int. #56

Closed AmyOlex closed 6 years ago

AmyOlex commented 6 years ago

The previous fix #55 created new error. When identifying month it now returns “sep”, which cannot be converted to a number in the buildChronoYear method. Gold has the value “SEP”, so I don’t think we want to lowercase when processing formatted dates. We also will need to check to ensure the characters being returned are a valid Month, and we need to stop converting to a number.

AmyOlex commented 6 years ago

Fixed this by expanding the utils method getMonthNumber() by expanding the dictionary to include more variations of month text representations. I also replaced a few instances where we convert an assumed number to a month text string using calendar.monthName(). Since these values are no longer assumed to be numbers I now used the previous method to convert. I think I could probably get rid of the calendar method all together by expanding my method even more, but I'll leave that for now.