An-Sar / Cyberware

Robotic Parts, port of Cyberware for Minecraft 1.12
https://minecraft.curseforge.com/projects/roboticparts
MIT License
13 stars 19 forks source link

Render incompatibilities with other custom players models #108

Open Kickiusz opened 5 years ago

Kickiusz commented 5 years ago

When using Armourer's Workshops (and probably other mods that change player model) skins, installing cyberlimbs makes one invisible. Which is fine, I expected that much. The problem is, the way Synthetic Skin works, it changes nothing in that regard - if one has cyberlimbs and synthetic skin, they still will be invisible while wearing AWs skins.

LemADEC commented 5 years ago

see #67 The rendering approach isn't compatible with other mods changing models.

mallrat208 commented 5 years ago

The only thing I can think of to improve upon the current method would be to instead add a LayerRenderer to players that enable rendering a certain part of the robotic/meat overlay based on installed augments.

The problem is I don't think it would actually help over much. It's better than flat out cancelling and replacing the render as is done now but I don't think it'll add to much in the way of compatibility.

LemADEC commented 5 years ago

Vampirism is changing entity faces with LayerRenderers, not sure how much compatible is it with other mods through.

Hydraheads commented 5 years ago

I also noticed installing better portals makes the player invisible with the cyber arms and ido makes the player's cyber arm not render while swimming/crawling. While vampirism seems to have problems with the latter as well, its method doesnt conflict with nearly as many mods as robotic parts from my experience.

LemADEC commented 5 years ago

ido?

LemADEC commented 4 years ago

The custom render can already be disabled to help with compatibility. Render layers don't work with limbs. As such, there's no easy fix for model rendering on 1.12.