An-Sar / Cyberware

Robotic Parts, port of Cyberware for Minecraft 1.12
https://minecraft.curseforge.com/projects/roboticparts
MIT License
13 stars 20 forks source link

Crash when inserting item into scanner. #168

Closed MrRedstoneA1 closed 2 years ago

MrRedstoneA1 commented 2 years ago

I inserted a hudlens into the scanner without any paper in it. The game instantly crashed. Crash log below. crash-2022-05-16_18.46.48-client.txt IMPORTANT EDIT: Discovered that this is due to my homemade custom resource pack that makes some of the cyber items have 3D models. As a result, every item I try to scan crashes the game.

LemADEC commented 2 years ago

what are your language setting when reproducing the issue? please try to reproduce in English? I bet you're in zh-cn which doesn't have a valid language resource file, here: https://github.com/An-Sar/Cyberware/blob/1.12/src/main/resources/assets/cyberware/lang/zh_cn.lang#L330-L406

MrRedstoneA1 commented 2 years ago

No, the language is en-us. I have however edited the lang file in the resource pack. After removing the katana json from the item models, it no longer crashes.

LemADEC commented 2 years ago

It sounds more likely that the edited lang file isn't respecting the contrains I've linked earlier?

MrRedstoneA1 commented 2 years ago

Might be. I'm testing again but I removed the lang folder. Now it should be using the mod's original en-us lang file.

MrRedstoneA1 commented 2 years ago

AHA, it seems to be the lang file. I removed some of the scanner sayings because I didn't need that many, maybe that plus the 3D item models caused the crash? I could give you a barebones resource pack that can replicate the crash.

MrRedstoneA1 commented 2 years ago

yup, no more crashes. Thank you very much for finding the issue, now I don't have to re-do a bunch of the items in my pack! Though I have never seen this kind of problem before, where a resource pack containing a modified lang file paired with 3D item models causes the game to crash. Very odd.

LemADEC commented 2 years ago

it's only the lang file that was invalid, you've removed a critical line, see the comments in the link I've posted. Eitherway, it's fixed.