[1.12.2] Cyberware rendering crash with Matter Overdrive Community edition.

[NovaLynxie]

Hi there, I have a rather annoying problem that seems to be caused by Cyberware clashing with Matteroverdrive. As soon as I try to add any cyberware arm or leg the game will instantly freeze and eventually crash due to the massive log spam in the console. This is what I am getting in the console. I have also got a crash report generated here: crash report in gist

[22:54:50] [Client thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.client.event.RenderPlayerEvent$Pre@96c6c48:
java.lang.StackOverflowError: null
    at java.security.AccessController.doPrivileged(Native Method) ~[?:1.8.0_333]
    at java.lang.ClassLoader.checkPackageAccess(Unknown Source) ~[?:1.8.0_333]
    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:188) ~[EventBus.class:?]
    at flaxbeard.cyberware.client.render.RenderPlayerCyberware.doRender(RenderPlayerCyberware.java:133) ~[RenderPlayerCyberware.class:?]
    at flaxbeard.cyberware.common.handler.EssentialsMissingHandlerClient.handleMissingSkin(EssentialsMissingHandlerClient.java:123) ~[EssentialsMissingHandlerClient.class:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_2192_EssentialsMissingHandlerClient_handleMissingSkin_Pre.invoke(.dynamic) ~[?:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
    at com.github.terminatornl.laggoggles.tickcentral.EventBusTransformer.redirectEvent(EventBusTransformer.java:67) ~[LagGoggles-1.12.2-5.8-132.jar:?]
    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) ~[EventBus.class:?]

To replicate this: Make sure to have Matter Overdrive Community Edition and Cyberware (1.12.2) installed. Get any cyber leg or arm and add it to your player with the robosurgeon and surgery chamber. Wait till it finishes the procedure, as soon as the damage ends. The game will freeze and log spam will start in the console.

Affected Mods: Cyberware v0.2.11 Matter Overdrive Community Edition v0.8.1 (1.12.2)

[LemADEC]

See #108 Also, there's probably a bug in MatterOverdrive checking android skin on non-android. Either way, as explained in the other issue, there's no API to deal with player rendering on 1.12.2, so you'll have to pick only one mod doing such thing

[NovaLynxie]

Hmm alright. Unfortunately, I cannot just rely on just Cyberware or MatterOverdrive as both mods are included in a modpack that uses both of these mods in its quests, removing either will break the questline progression. Modpack in question is Planetary As for the possible bug for checking android skins on non-androids, I'll see if MO devs can figure this out from their end.

[NovaLynxie]

Ok, done some more testing even though issue is closed. It is definitely an issue with MO Community edition and Cyberware. Tried Matter Overdrive Legacy edition as an alternative which worked just fine without the crash/freeze symptoms. Will follow up with them and see what's going on.

[LemADEC]

carefully read again my previous comment and the linked issue

[NovaLynxie]

carefully read again my previous comment and the linked issue

I did try what was mentioned in the linked issue and found the setting in cyberware that helped as a workaround to stop the crashing issue I had while testing yesterday. But as I said yesterday, the modpack I found the bug in requires both mods so again I can't just take one of them out. It is not my modpack either which I forgot to mention.

[LemADEC]

It's not about removing mods. It's about disabling the custom rendering. You can't have BOTH RENDER active. Pick one and stick to it.

[NovaLynxie]

Ah, I see. Sorry for the misunderstanding.