search

An-dz / VSDGenerator

An extension for the Vivaldi browser to automatically generate cool Speed Dial images.
BSD 2-Clause "Simplified" License
32 stars 2 forks source link

Fix YT Links #2

Closed dag7dev closed 3 years ago

dag7dev commented 3 years ago

Today I discovered this ext: thanks for this, it is really nice!

However there is a thing that it is really annoying: when dealing with youtube links, 90% of the time the addon fails to fetch the image, so it will add a blank thumbnail.

I suggest to implement: "in case URL I am dealing with, is made with this structure ".youtube.com/watch?v=", then download and set the thumbnail from "http://img.youtube.com/vi/[video-id]/maxresdefault.jpg"

dag7dev commented 3 years ago

Example links to be clearer: https://www.youtube.com/watch?v=QqTpnRHklpA and https://www.youtube.com/watch?v=W6qriAJy7fs Addon doesn't fetch 90% of time (it works with no problem for this: https://www.youtube.com/watch?v=XFUHGT3qWAw)

An-dz commented 3 years ago

I've made a complete rewrite of the code, I'm still testing locally but will release once I feel confident it works, I'll test YouTube probably in the weekend and if it goes well I'll release v2.

dag7dev commented 3 years ago

Glad to hear some news! Cant wait to try it out!

An-dz commented 3 years ago

Version 2.0 has been released and my tests have not failed for any of the provided links.