search

An00nymushun / DiscordFreeStickers

Convert APNG and Lottie into GIF on Discord
GNU Lesser General Public License v2.1
147 stars 129 forks source link

Crashes Discord when pressing the Stickers Button on powercord #9

Closed PeterStrick closed 2 years ago

PeterStrick commented 2 years ago

The Plugin crashes Discord entirely upon pressing the Stickers button, when using Powercord.

OS: Windows 8.1 x64 Discord Canary Version: 107393 (d1677d6) Powercord Revision | Branch: 1d2318b (latest) | v2 bdCompat Version: v0.3.10 DiscordFreeStickers Version: v1.1

Error in Console: image image

An00nymushun commented 2 years ago

I'm pretty sure it's an issue with bdCompat https://github.com/Juby210/bdCompat/blob/d758d7fbed95c37b6921244c1215727f2ac4ddef/modules/Patcher.js#L74 It should pass callOriginalMethod instead of returnValue if it's an instead hook.

Why not just use BD?

PeterStrick commented 2 years ago

I'm pretty sure it's an issue with bdCompat https://github.com/Juby210/bdCompat/blob/d758d7fbed95c37b6921244c1215727f2ac4ddef/modules/Patcher.js#L74 It should pass callOriginalMethod instead of returnValue if it's an instead hook.

Why not just use BD?

Eh it´s personal preference. Also thought that it would work fine under Powercord, because your Free Emoji Plugin does.

An00nymushun commented 2 years ago

The Free Emojis plugin works, but powercord people will literally harass you on their server if they find out you are using it.

PeterStrick commented 2 years ago

but powercord people will literally harass you on their server if they find out you are using it.

Good to know