AnAkkk / TFTrue

http://tftrue.esport-tools.net/
GNU General Public License v2.0
37 stars 12 forks source link

Airshot stats inflated in logs #66

Open bzknz opened 2 years ago

bzknz commented 2 years ago

We run a PUG server in South Africa and recently migrated to TFTrue. Everything appears to be working with the logs except that the airshot stats appear to be inflated. Not sure if this is a config issue or something else.

We are running TFTrue version 4.86. We are running this version of the ETF2L config: https://github.com/ETF2L/gameserver-configs/releases/tag/1.0.3

Here are some examples: https://logs.tf/3193689#76561199085369255 https://logs.tf/3193750#76561199085369255 https://logs.tf/3193800#76561199085369255 https://logs.tf/3193816#76561199085369255

I've included as many details as I can think of but let me know if you'd like anything else:

sm plugins list
[SM] Listing 27 plugins:
  01 "SOAP TF2 Deathmatch" (4.4.4) by Icewind, MikeJS, Lange, Tondark - maintained by sappho.io
  02 "SOAP Tournament" (3.8.5) by Lange - maintained by sappho.io
  03 "Client Preferences" (1.10.0.6539) by AlliedModders LLC
  04 "Improved Pause Command" (1.4.2) by Aad
  05 "MapChooser" (1.10.0.6539) by AlliedModders LLC
  06 "Player Commands" (1.10.0.6539) by AlliedModders LLC
  07 "Sound Commands" (1.10.0.6539) by AlliedModders LLC
  08 "SwapTeam" (1.2.6) by Rogue - Originally by MistaGee
  09 "Fun Votes" (1.10.0.6539) by AlliedModders LLC
  10 "Basic Ban Commands" (1.10.0.6539) by AlliedModders LLC
  11 "Basic Info Triggers" (1.10.0.6539) by AlliedModders LLC
  12 "Rock The Vote" (1.10.0.6539) by AlliedModders LLC
  13 "Nextmap" (1.10.0.6539) by AlliedModders LLC
  14 "Basic Comm Control" (1.10.0.6539) by AlliedModders LLC
  15 "Class Warning" (1.1.0) by F2
  16 "Admin File Reader" (1.10.0.6539) by AlliedModders LLC
  17 "Map Nominations" (1.10.0.6539) by AlliedModders LLC
  18 "Basic Votes" (1.10.0.6539) by AlliedModders LLC
  19 "Admin Menu" (1.10.0.6539) by AlliedModders LLC
  20 "Fun Commands" (1.10.0.6539) by AlliedModders LLC
  21 "TF2 Competitive Fixes" (1.16.10) by ldesgoui
  22 "Anti-Flood" (1.10.0.6539) by AlliedModders LLC
  23 "Basic Chat" (1.10.0.6539) by AlliedModders LLC
  24 "Admin Help" (1.10.0.6539) by AlliedModders LLC
  25 "Basic Commands" (1.10.0.6539) by AlliedModders LLC
  26 "AFK Detector" (1.1.0) by F2
  27 "Reserved Slots" (1.10.0.6539) by AlliedModders LLC
sm version
 SourceMod Version Information:
    SourceMod Version: 1.10.0.6539
    SourcePawn Engine: 1.10.0.6539, jit-x86 (build 1.10.0.6539)
    SourcePawn API: v1 = 5, v2 = 12
    Compiled on: May  9 2022 21:25:39
    Built from: https://github.com/alliedmodders/sourcemod/commit/315b79f
    Build ID: 6539:315b79f
    http://www.sourcemod.net/
meta list
Listing 5 plugins:
  [01] SourceMod (1.10.0.6539) by AlliedModders LLC
  [02] TF2 Tools (1.10.0.6539) by AlliedModders LLC
  [03] SDK Hooks (1.10.0.6539) by AlliedModders LLC
  [04] SDK Tools (1.10.0.6539) by AlliedModders LLC
  [05] DHooks (2.2.0-detours17) by Dr!fter and Peace-Maker
meta version
 Metamod:Source Version Information
    Metamod:Source version 1.11.0-dev+1145
    Plugin interface version: 16:14
    SourceHook version: 5:5
    Loaded As: Valve Server Plugin
    Compiled on: Jul 11 2021 22:32:11
    Built from: https://github.com/alliedmodders/metamod-source/commit/0bb53f2
    Build ID: 1145:0bb53f2
    http://www.metamodsource.net/
tftrue_logs_prefix
"tftrue_logs_prefix" = ""
 - Prefix to add in the log name when uploading to logs.tf
tftrue_logs_roundend
"tftrue_logs_roundend" = "1" min. 0.000000 max. 1.000000
 notify
 - Upload logs at every round end.
tftrue_logs_includebuffs
"tftrue_logs_includebuffs" = "1" min. 0.000000 max. 1.000000
 notify
 - Includes buffs within the player_healed event in the logs.
tftrue_logs_accuracy
"tftrue_logs_accuracy" = "0" min. 0.000000 max. 1.000000
 notify
 - Log shots and hits for accuracy stats.
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.4 LTS
Release:        20.04
Codename:       focal
$ uname -a
Linux <redacted> 5.13.0-1027-oracle #32~20.04.1-Ubuntu SMP Fri Apr 15 05:59:34 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
TheBv commented 2 years ago

Could you provide an stv so one can compare the log files with what is happening in game?

Arie commented 2 years ago

You're probably not expecting that non directs also count as airshots by definition. So splash damage from a wall hitting a player xxx units above ground, will count as an airshot.

bzknz commented 2 years ago

Could you provide an stv so one can compare the log files with what is happening in game?

Unfortunately we don't have STVs of these games. I'll look into setting that up in the future.

bzknz commented 2 years ago

You're probably not expecting that non directs also count as airshots by definition. So splash damage from a wall hitting a player xxx units above ground, will count as an airshot.

Ah right, that makes sense. We were using the F2 plugins before that to my knowledge were only recording direct (non-splash) airshots.

Arie commented 2 years ago

You're probably not expecting that non directs also count as airshots by definition. So splash damage from a wall hitting a player xxx units above ground, will count as an airshot.

Ah right, that makes sense. We were using the F2 plugins before that to my knowledge were only recording direct (non-splash) airshots.

Indeed it does look like that: https://github.com/F2/F2s-sourcemod-plugins/blob/1fc730995a7cc7b068a06c8b7bf3970f298f6e8b/supstats2/supstats2.sp#L637