search

AnHardt / Marlin

Reprap FW with look ahead. SDcard and LCD support. It works on Gen6, Ultimaker, RAMPS and Sanguinololu
GNU General Public License v3.0
1 stars 1 forks source link

Switch SD2cadrLib to fastio #61

Closed AnHardt closed 7 years ago

AnHardt commented 7 years ago

Clean out SD2PinMap.h to the bare bare definitions of the hardware SPI pins. The definition can easily be overwritten from the boars pinfiles.

thinkyhead commented 7 years ago

I see Temperature.cpp wants to #include "Sd2PinMap.h" for some reason.

AnHardt commented 7 years ago

Yea - surprised me too. But for sure it has to do with the MAX6675 and co.

AnHardt commented 7 years ago

Tried to solve that by assuming - a second, unconditional init of the SPI-hardware can't hurt. The pin definitions come from fastio.h now anyway. And here for the MAX we have the next halve SPI implementation.

thinkyhead commented 7 years ago

Wow. If this is all the change needed, and we have confidence, then I would enjoy merging it and saving more CPU cycles.

thinkyhead commented 7 years ago

If the SDSS pin is always using "Teensyduino" pin mapping, I suppose we could put a comment on it in all the pins files so we don't forget. And generally make sure all the pin mappings (if out of the ordinary) are commented to be more obvious.

AnHardt commented 7 years ago

Let's again have a look on what we remove and how we replace it.