search

AnKing-VIP / AnkiRecolor

Recolor addon commissioned by and created for AnKing
38 stars 6 forks source link

Sorted themes list in menu #6

Closed madmaximux closed 2 years ago

madmaximux commented 2 years ago
BlueGreenMagick commented 2 years ago

Thanks! Merged sorting theme names.

But as for the second commit, I think it's better to group dark themes and light themes. Moving (dark) to the end mixes them up.

madmaximux commented 2 years ago

I guess it's a matter of preference here. Group all darks and lights together or group them alphabetically, by theme name, so that when you scroll down to a theme name, you have a choice to pick light or dark.

PS. The Solarized dark and light themes were created by two different people. Which is why I left it as-is vs merging them.

AnKingMed commented 2 years ago

@madmaximux has a point with their being two solarized themes, they'd line up better with (dark) being place after. I see the benefit of putting (dark) before as well to group them. It probably just comes down to preference and it may become more clear as we have more themes