Update for 2.1.45 - Githubissues

RumovZ commented 3 years ago

With this PR, advanced browser can be run on the ~latest~ next beta (2.1.45b~6~7). See 01cb415 for some reasoning. Also closes #125 and fixes #123. What this PR doesn't do:

Fix the editing functions (with the exception of flags, 49b44ad).
Make use of new columns, which allow customising alignment, sort order etc.
Use aggregated data in notes mode. Instead, the data for the first card of each note is shown.
~Fix an issue, where the headers are not restored correctly the first time. I intend to address this after https://github.com/ankitects/anki/pull/1277 has been merged, which will allow us to drop most of the remaining monkey patching.~

hssm commented 3 years ago

I'll try to look at this over the weekend.

hssm commented 3 years ago

Sorry for the delay. First, thanks for all of your recent work on Anki and for taking the time to update this add-on.

I have given your changes a test and things seem to work well so I'm happy to merge this and release it as-is.

One issue I've noticed is the presence of an 'Add-on' column when switching to note mode, even in a new profile.

Unfortunately, I don't have the time or the motivation to work on this add-on anytime soon, and the regular large changes recently have made me reluctant to sink any more time into it. At this point I'm willing to hand over ownership of the add-on if you or @Arthur-Milchior are interested in it. I don't think I'm the right person for this anymore.

Or perhaps it's a good time to consider adding the add-on's features into Anki itself.

RumovZ commented 3 years ago

One issue I've noticed is the presence of an 'Add-on' column when switching to note mode, even in a new profile.

That's strange. Maybe that's from another add-on? Add-on columns can now be simply toggled off via the GUI. But before you do, you could look at the console output for pp(self.col.get_config("advbrowse_activeNoteCols")) to learn its identifier.

At this point I'm willing to hand over ownership of the add-on if you or @Arthur-Milchior are interested in it.

That's a pity, but understandable, of course. I'm sure someone will take over, so your great work will continue to make Anki users happy. I'm curious what Arthur will say.

Or perhaps it's a good time to consider adding the add-on's features into Anki itself.

Let's ask @dae.

Arthur-Milchior commented 3 years ago

I'm fine with taking ownership. Obviously, I'm even more fine with having it incorporated into anki, and am willing to help doing so if @dae accepts. In any case, @dae , I'd appreciate if you could transfer the add-on ownership on ankiweb

dae commented 3 years ago

Would prefer to keep it separate for now; we can revisit that question in the future when there aren't so many other things going on. @ankingmed also expressed interest in possibly looking after it, so if you could work it out between the two of you and then get @hssm to confirm, I can transfer the add-on to whichever account you decide on.

Seconding Rumo's comments, thank you for all of the work you've put into this and your other add-ons @hssm!

AnKingMed commented 3 years ago

I'm happy to do whatever. What I would do is create a repo under anki palace and add @Arthur-Milchior to it. I've done this with Special Fields and it's been very easy to manage because I can publish the add-on after anyone works on it. @Arthur-Milchior if you'd rather just takeover, I'm happy to do that as well

hssm commented 3 years ago

It's your call Arthur. I'm handing the add-on over to you; if you think it's easier to collaborate with @AnKingMed under anki palace (I will admit I don't know anything about this) then it's fine with me.

Arthur-Milchior commented 3 years ago

Fine for @AnKingMed 's ankipalace. Just discussed it with The AnKing, and I'm excited to see how it'll work.

hssm commented 3 years ago

Great. I've merged this commit. If you'd like me to upload a release I can do that, otherwise I'll leave the rest up to you guys.

AnKingMed commented 3 years ago

Can you transfer ownership of this repo to ankipalace? I'll keep you added to it, but then I can control who to add to the repo

@dae can you transfer the addon to ankipalaceaddons@gmail.com on ankiweb?

hssm commented 3 years ago

You mean https://github.com/ankipalace ?

AnKingMed commented 3 years ago

Yea that's the one

hssm commented 3 years ago

Tried:

You don’t have the permission to create public repositories on ankipalace

AnKingMed commented 3 years ago

You should be able to just transfer ownership. https://docs.github.com/en/github/administering-a-repository/managing-repository-settings/transferring-a-repository

hssm commented 3 years ago

Seems there are limitations if it's to an organization:

To transfer a repository that you own to an organization, you must have permission to create a repository in the target organization.

AnKingMed commented 3 years ago

Oh weird. You can just transfer to me then and I'll do it.

AnKing-VIP / advanced-browser

Update for 2.1.45 #126