AnKing-VIP / advanced-browser

Anki add-on with card browser enhancements.
GNU General Public License v3.0
58 stars 13 forks source link

2.1.41-2.1.44 branch is broken #151

Closed abdnh closed 2 years ago

abdnh commented 2 years ago

After testing #148 and #149, I went to test the 2.1.41-2.1.44 branch and hit another error.

image

The aqt.operations submodule was added in 2.1.45, so this branch is probably broken in all versions it claims to support.

abdnh commented 2 years ago

I'll look into sending a fix for this.

@ijgnd BTW, I see the older AnkiWeb branches are not managed with Git branches here. Maybe they should be uploaded so that it's easier to apply fixes?

ijgnd commented 2 years ago

that's an important find.

I probably should have been more precise when asking ankingmed for uploading your fix.

We should revert to the prior version. As far as I see that was the version from 2021-07-23 though the appropriate commit is 6d4ea7b from 2021-02-22 (the last one before rumovz made the changes for .45). Do you happen to have an old file from ankiweb otherwise I'll zip the repo as of commit 6d4ea7b.

ijgnd commented 2 years ago

I'll look into integrating the old branches into git later today.

abdnh commented 2 years ago

Do you happen to have an old file from ankiweb

No, I don't have the zip.

ijgnd commented 2 years ago

since I didn't find an old version to patch I zipped it from an old commit.

the code is identical (apart from yesterday's patch) to the AB code I have in a backup from 2021-07.

github doesn't allow to upload .ankiaddon files so I added the extension .zip which must be removed before using this file.

advanced_browsergit_6d4ea7b_from_2021-02-22__Version_39forAnki41-44__with_abdnhs_overdue_fix_license.ankiaddon.zip

ijgnd commented 2 years ago

ankingmed will upload the patched version lateer today.

ijgnd commented 2 years ago

@abdnh

@ijgnd BTW, I see the older AnkiWeb branches are not managed with Git branches here. Maybe they should be uploaded so that it's easier to apply fixes?

I added git branches corresponding to the ankiweb releases of AB, see my new comment on top of the readme.md file. To the branches for Anki 2.1.24+ I applied your overdue ivl patches.

I hope this is what you had in mind.