AnKing-VIP / advanced-browser

Anki add-on with card browser enhancements.
GNU General Public License v3.0
58 stars 13 forks source link

prepare next release #156

Closed ijgnd closed 1 year ago

ijgnd commented 2 years ago

Additionally I added two new columns:

@AnKingMed: After your holiday have a look at my two new columns, do a quick test on 2.1.45+ (you need to checkout these branches separately and test them individually) and see if you want them included into the AB browser add-on. Then I can merge these branches and build a new release for 2.1.45 that you can upload to ankiweb.

ijgnd commented 2 years ago

to make testing more convenient: here is one file that contains the changes from both branches mentioned in the first post. This is for .45+ only. Since github does not allow to upload files with the extension ".ankiweb" I added ".zip" to the filename which you need to remove before you install it into Anki.

When testing keep in mind that "% of scheduled interval" only works for cards in review that are not in relearing (search term: is:review -is:learn"). For me it doesn't make sense to calculate the overdueness of learn cards by the minute. i also calculate no value for cards that you relearn. That was easier to code and the question is which is the relevant overdue interval: in reference to your relearning steps or the interval that you get after this with the "new interval" setting?

About the Total again count: if it's zero the column is empty.

Advanced_Browserbranch_idx_4AnkiVers_45-542022-10-08both_new_features_merged_ijgnd.ankiaddon.zip

ijgnd commented 2 years ago

@AnKingMed : see https://github.com/ankipalace/advanced-browser/issues/156#issuecomment-1272263942

ijgnd commented 1 year ago

@AnKingMed: when you have some time left over: In October I added two new columns to the Advanced Browser: "% of scheduled interval" and "Total Again Count". If you like these the code needs some testing before this version can be released. the ankiaddon file is in the second post in this thread.

AnKingMed commented 1 year ago

These are really cool. I tested and things look great. Again count seems very useful to me. I'm not sure I understand "% of scheduled interval".
Could you explain this more and how one would use it?

Let me know when to release this and I'm happy to

ijgnd commented 1 year ago

My motivation for "% of scheduled interval":

this column might be useful if you want to study your most overdue cards in random order. You can sort filtered decks by relative overdueness. But if you created two notes with similar content and studied them only once or twice they will have seen little fuzz to their intervals so that they'll have very similar overdue values so that when sorting the cards by relative overdueness they'll be shown closely together. I prefer fully randomized reviews that I can get by building a filtered deck from selected cards in the browser when the browser table is sorted by "% of scheduled interval".

I originally had the code study the most "underdue" cards. But for this use case now there's the add-on Smarter Study Ahead

 

I think you could release them now. But releasing them is not important since very few people will use these, I guess. I mainly cared if they can be merged into the main branch of this add-on so that they are automatically included in the next release so that I don't have to build custom versions each time a new Advanced Browser version is released.

I asked you about checking the commits now because I still remember making these commits ...

AnKingMed commented 1 year ago

What is the actual calculation you are using for % of scheduled interval? (Just curiosity)

Also I'm totally fine merging this in and releasing it now!

ijgnd commented 1 year ago

I use this:

last_rev = card.due - card.ivl
elapsed = mw.col.sched.today - last_rev
val = elapsed/float(card.ivl) * 100
....
fmt = "{0:.2f}".format(val) + " %"
AnKingMed commented 1 year ago

Awesome. Thanks! I was just curious. You can go ahead and merge the branches. You should have permissions

ijgnd commented 1 year ago

Thanks for your review. I've merged these. This is not my add-on so I prefer getting a second opinion.

AnKingMed commented 1 year ago

Should I just upload the file you sent here to AnkiWeb? for 2.1.45+ correct?

ijgnd commented 1 year ago

it's 2.1.45+

to be on the safe side I'd like to check this on the weekend.

AnKingMed commented 1 year ago

Ok let me know. If you could just upload a new release I will download that file and release it

ijgnd commented 1 year ago

yes the file I posted on 2022-10-08 can be uploaded for 2.1.45.

It's identical to building from the master branch of this addon with python3 release.py and it's what I've been using the last two months.

ijgnd commented 1 year ago

off-topic: the download link for the addon newly released "Spell Checker" on ankipalace.com is broken. It leads to an error page and if you extract the bitly part it leads to the weekends add-on

AnKingMed commented 1 year ago

Just fixed this. Can you try again?

ijgnd commented 1 year ago

the spell checker download link now works as expected

AnKingMed commented 1 year ago

Great. Thanks for reporting that!