AnOpenSauceDev / FasterParticleCollisions

A standalone version of a Methane particle "Optimization"
Other
1 stars 0 forks source link

Java 21 required for 1.20.1 #3

Open owosoup opened 1 month ago

owosoup commented 1 month ago

The fabric loader throws an error at startup saying this mod requires java 21 to run, but I'm on a 1.20.1 instance that uses java 17. I can indeed run 1.20.1 with java 21 too, but I sometimes get crashes... can the mod use 17 instead?

By the way I have another question, if this mod is installed alongside particle core, will it have any effect? Will the patch "throw out" particle core's optimizations ? Thanks:)

AnOpenSauceDev commented 1 month ago

I can change the Java requirements, the default mod templates always set the latest Java version just so developers don't push code that would break older Java versions. I'll write an update to support Java 17 and probably clean some stuff up before publishing it.

Will the patch "throw out" particle core's optimizations?

As of when I last looked into Particle Core's source, nothing it did conflicted with what this mod did (not that I really think it would do something as destructive as this mod does), and I have used both together recently without any issues. So, both of these mods should work fine together.

I hope that answers both of your questions!

AnOpenSauceDev commented 1 month ago

Apologies, I couldn't work on this update until today.

I have now uploaded the fix (https://github.com/AnOpenSauceDev/FasterParticleCollisions/commit/9221df90b6aa0ff69da2c84a7031b83471b94150) onto Modrinth and fixed up the repo. Let me know if that fixes the problem!