AnOpenSauceDev / Methane-mod

A 1.19+ performance mod for the Fabric and Quilt modloaders.
MIT License
49 stars 12 forks source link

Crash with Moonlight Lib (Cannot Reproduce) #87

Closed ImLuni5 closed 7 months ago

ImLuni5 commented 7 months ago

🔥 Something broke!

Description of what happened

Crash when Hypixel Jump Boost

Mods used

async-pack-scan: Async Pack Scan 0.2.2
badoptimizations: BadOptimizations 2.0.1
betterpingdisplay: Better Ping Display 1.1.1
c2me: Concurrent Chunk Management Engine 0.2.0+alpha.11.58
clientsidenoteblocks: ClientSideNoteblocks 2.6
cloth-config: Cloth Config v13 13.0.121
continuity: Continuity 3.0.0-beta.4+1.20.2
dark-loading-screen: Dark Loading Screen 1.6.14
debugify: Debugify 1.20.4+1.0
dynamic_fps: Dynamic FPS 3.3.3
enhancedblockentities: Enhanced Block Entities 0.9.1+1.20.2
entityculling: EntityCulling 1.6.3.1
exordium: Exordium 1.2.1
fabric-api: Fabric API 0.91.1+1.20.4
faster-random: Faster Random 3.0.1
fastpaintings: Fast Paintings 1.20.4-1.2.7
ferritecore: FerriteCore 6.0.3
immediatelyfast: ImmediatelyFast 1.2.10+1.20.4
indium: Indium 1.0.30+mc1.20.4
krypton: Krypton 0.2.6
lithium: Lithium 0.12.1
memoryleakfix: Memory Leak Fix 1.1.5
methane: Methane 3.5.0
modernfix: ModernFix 5.13.0+mc1.20.4
modmenu: Mod Menu 9.0.0
moonlight: Moonlight Lib 1.20.4-2.10.3
moreculling: More Culling 1.20.4-0.22.1
noxesium: Noxesium 1.2.0+669ccb7
packetfixer: Packet Fixer 1.2.4
reeses-sodium-options: Reese's Sodium Options 1.7.2+mc1.20.4-build.102
rrls: Remove Reloading Screen 4.0.1+mc1.20.4-fabric
servercore: ServerCore 1.4.0+1.20.3
serverpingerfixer: Server Pinger Fixer 1.0.4
sodium: Sodium 0.5.8+mc1.20.4
sodium-extra: Sodium Extra 0.5.4+mc1.20.4-build.116
stutterfix: StutterFix mc1.20.3-0.2.0
vmp: Very Many Players 0.2.0+beta.7.138
yet_another_config_lib_v3: YetAnotherConfigLib 3.3.2+1.20.4

https://gist.github.com/ImLuni5/bf651c8926f4de613cd8f4d0c76305ac

Methane Version

Methane - 3.5.0: 1.20.4

possible ways to replicate this bug

go hypixel arcade lobby and step slime jump boost and see npcs then disconnected, with this exception:

Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: readerIndex(16398) + length(1) exceeds writerIndex(16398): PooledUnsafeDirectByteBuf(ridx: 16398, widx: 16398, cap: 16398)

after this, rejoin hypixel and if you step slime jump boost, always crash!

AnOpenSauceDev commented 7 months ago

I'll look into it, but i can tell you that the crash is from Dynamic Shading.

AnOpenSauceDev commented 7 months ago

Odd, I'm not crashing. Might be another mod's problem.

ImLuni5 commented 7 months ago

hmm, maybe c2me?

AnOpenSauceDev commented 7 months ago

Looking at the error, it looks like it has something to do with sodium, but i still can't replicate. It also has something to do with chunk rebuilding, so it might be c2me.

AnOpenSauceDev commented 7 months ago

Nope, not C2ME either it seems. Try updating your mods to be safe.

ImLuni5 commented 7 months ago

I found the cause. Once I removed Moonlight Lib, the crashes stopped occurring. It seems that Methane and Moonlight Lib are incompatible with each other.

AnOpenSauceDev commented 7 months ago

I'll have to look into that tomorrow.

AnOpenSauceDev commented 7 months ago

I've been trying for a while cannot replicate this crash in any way with Moonlight Lib. I'm closing, as this can't be replicated.